Skip to content

[do not merge] crater dbg! changes against stable-1.95.0#156106

Closed
dianne wants to merge 8 commits intorust-lang:stablefrom
dianne:dbg-crater
Closed

[do not merge] crater dbg! changes against stable-1.95.0#156106
dianne wants to merge 8 commits intorust-lang:stablefrom
dianne:dbg-crater

Conversation

@dianne
Copy link
Copy Markdown
Contributor

@dianne dianne commented May 3, 2026 •
edited by rustbot
Loading

stable backport of #155915 for crater

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 3, 2026
@dianne
Copy link
Copy Markdown
Contributor Author

dianne commented May 3, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
@bors
Auto merge of #156106 - dianne:dbg-crater, r=<try>
1190584 
[do not merge] crater `dbg!` changes against stable-1.95.0
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

💔 Test for 1190584 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dianne
Copy link
Copy Markdown
Contributor Author

dianne commented May 3, 2026 •
edited
Loading

do I need to make an imaginary version bump? I guess I can try that

I guess I could also maybe have made this PR against the beta branch and just ignored the known regressions in the crater results? I'm not sure what the usual process is for cratering isolated changes against stable

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels May 3, 2026
@dianne
Copy link
Copy Markdown
Contributor Author

dianne commented May 3, 2026

sorry if that pinged anyone! maybe I need to make a fake point release? though just in case, @bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
@bors
Auto merge of #156106 - dianne:dbg-crater, r=<try>
eed2451 
[do not merge] crater `dbg!` changes against stable-1.95.0
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

rust-log-analyzer commented May 3, 2026

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  CACHE_DOMAIN: ci-caches.rust-lang.org
  PR_CI_JOB: 1
  IMAGE: pr-check-1
##[endgroup]
error: PRs changing the `beta` channel should be sent to the `beta` branch!
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

☀️ Try build successful (CI)
Build commit: eed2451 (eed2451ff9b5f723c5709802779b044cd4dfff59, parent: 59807616e1fa2540724bfbac14d7976d7e4a3860)

@dianne
Copy link
Copy Markdown
Contributor Author

dianne commented May 3, 2026

closing in favor of crater run directly on #155915

@dianne dianne closed this May 3, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dianne @rust-log-analyzer @rustbot @joboet